Skip to content

Improve ImpTest helpers #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 29, 2025
Merged

Improve ImpTest helpers #5220

merged 12 commits into from
Sep 29, 2025

Conversation

@Lucsanszky
Copy link
Contributor

@Lucsanszky Lucsanszky commented Aug 11, 2025 •
edited
Loading

Description

Follow-up to #5137

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Lucsanszky Lucsanszky changed the base branch from master to ldan/dijkstra-certs August 11, 2025 17:14
@Lucsanszky Lucsanszky changed the base branch from ldan/dijkstra-certs to master August 11, 2025 17:15
@Lucsanszky Lucsanszky mentioned this pull request Aug 27, 2025
Merged
10 tasks
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch 4 times, most recently from 2997716 to a5d8109 Compare September 5, 2025 10:17
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch from c7f0287 to 8155e7c Compare September 9, 2025 16:48
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch 3 times, most recently from 4dffd56 to 4bbc441 Compare September 17, 2025 22:51
@Lucsanszky Lucsanszky marked this pull request as ready for review September 17, 2025 22:52
@Lucsanszky Lucsanszky requested a review from a team as a code owner September 17, 2025 22:52
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch 2 times, most recently from ca9c96d to 318a7dc Compare September 19, 2025 12:26
@Lucsanszky Lucsanszky mentioned this pull request Sep 19, 2025
Merged
10 tasks
teodanciu
teodanciu approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments from me.
I love it, it's so cool how introducing these two methods genRegTxCert and genUnRegTxCert made it possible to remove all these variations of functions

Looks good to me, barring some version changes and changelog suggestions.

@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch 2 times, most recently from 2a38bec to 3a5ba4d Compare September 25, 2025 23:40
Lucsanszky
Lucsanszky commented Sep 25, 2025
View reviewed changes
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch 3 times, most recently from 69f068d to 0a24040 Compare September 26, 2025 17:57
lehins
lehins approved these changes Sep 26, 2025
View reviewed changes
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you!

@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch 2 times, most recently from 9aa07d4 to b64db3a Compare September 26, 2025 20:13
@Lucsanszky
Remove registerPoolWithDeposit
2700d2d
@Lucsanszky
Remove registerRewardAccountWithDeposit
ca14ea0
@Lucsanszky
Use certs w/out deposits in some script validation tests
3d607b1 
For some reason, these tests fail if we use certificates with deposits,
so as a temporary measure we will avoid using deposits in these cases.

Related: #4571
@Lucsanszky
Remove shelleyEraSpecificSpec
9dd213b 
No longer necessary since the introduction of `genRegTxCert`,
`genUnRegTxCert` `ShelleyEraImp` typeclass methods.
@Lucsanszky
Remove regDelegToDRep helper
d517778 
This reverts commit 9a06817
and related changes.
@Lucsanszky
Move some alonzoEraSpecificSpec tests
edf5afc
@Lucsanszky
Remove babbageEraSpecificSpec
e311858 
No longer necessary since the introduction of `genRegTxCert`,
`genUnRegTxCert` `ShelleyEraImp` typeclass methods.
@Lucsanszky
Move a conwayEraSpecificSpec testcase
bdcc2c0
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch 2 times, most recently from 8f92290 to 3c72d20 Compare September 29, 2025 14:18
@Lucsanszky Lucsanszky force-pushed the ldan/imptest-improvements branch from 3c72d20 to e2ea84f Compare September 29, 2025 15:51
@Lucsanszky Lucsanszky merged commit d38772f into master Sep 29, 2025
122 checks passed
@Lucsanszky Lucsanszky deleted the ldan/imptest-improvements branch September 29, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teodanciu teodanciu teodanciu approved these changes

@lehins lehins lehins approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lucsanszky @teodanciu @lehins